Skip to content

fix(frontend): legend overlapping dropdown on small breakpoints #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

tylersayshi
Copy link
Contributor

fixes #1056

image

@CLAassistant
Copy link

CLAassistant commented Apr 22, 2025

CLA assistant check
All committers have signed the CLA.

@tylersayshi
Copy link
Contributor Author

it seems to do well with smaller screens and many versions as well, but it does get close

image

@crowlKats
Copy link
Collaborator

@tylersayshi could you sign the CLA? would like to get this landed

@tylersayshi
Copy link
Contributor Author

@tylersayshi could you sign the CLA? would like to get this landed

signed and fixed the merge conflicts!

@tylersayshi
Copy link
Contributor Author

oh wait the diff looks wrong now... marking as draft while I check that

@tylersayshi tylersayshi marked this pull request as draft April 25, 2025 02:38
@tylersayshi tylersayshi marked this pull request as ready for review April 25, 2025 02:42
@tylersayshi
Copy link
Contributor Author

all ready now from my end 🚀

@tylersayshi tylersayshi force-pushed the fix-download-legend branch from 9863e69 to cb601f9 Compare April 25, 2025 02:56
@tylersayshi tylersayshi marked this pull request as draft April 25, 2025 02:58
@tylersayshi tylersayshi force-pushed the fix-download-legend branch from cb601f9 to f6d7e4d Compare April 25, 2025 02:59
@tylersayshi tylersayshi marked this pull request as ready for review April 25, 2025 02:59
@tylersayshi
Copy link
Contributor Author

rebase and force push was for fixing the commit authors (apologies for all the notifications)

Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@crowlKats crowlKats added this pull request to the merge queue Apr 25, 2025
Merged via the queue into jsr-io:main with commit b65bdf2 Apr 25, 2025
7 checks passed
@tylersayshi tylersayshi deleted the fix-download-legend branch April 25, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

download charts legend overlaps on thin screens
3 participants